Remove panic from crdt counter #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## main #598 +/- ##
==========================================
- Coverage 51.47% 51.19% -0.29%
==========================================
Files 66 67 +1
Lines 6962 7053 +91
==========================================
+ Hits 3584 3611 +27
- Misses 2904 2960 +56
- Partials 474 482 +8
|
krapie
previously approved these changes
Aug 6, 2023
krapie
requested changes
Aug 6, 2023
To prevent stopping the server in production environment, the panic methods were replaced with error methods. Modify test codes for counter As the panic methods in counter were replaced, the related test codes also were modified. Add error check for Increase method of counter Add error check for Increase method of counter
MoonGyu1
force-pushed
the
remove-panic-from-crdt-counter
branch
from
fd8f68d
to
e6200ba
Compare
hackerwins
approved these changes
Aug 7, 2023
hackerwins
pushed a commit
that referenced
this pull request
Aug 7, 2023
To prevent stopping the server in the production environment, the panic methods were replaced with error methods. Modify test codes for counter As the panic methods in the counter were replaced, the related test codes also were modified.
Wu22e
pushed a commit
to Wu22e/yorkie
that referenced
this pull request
Sep 3, 2023
To prevent stopping the server in the production environment, the panic methods were replaced with error methods. Modify test codes for counter As the panic methods in the counter were replaced, the related test codes also were modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove the panic methods in
crdt/counter.goWhich issue(s) this PR fixes:
Related to #497 (
crdt/counter)Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: