Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'Documents' from plural to singular in DocEvent #613

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

chacha912
Copy link
Contributor

What this PR does / why we need it:

Change "documents" to "document" in DocEvent

Which issue(s) this PR fixes:

Fixes #612

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #613 (9953d5a) into main (932a9c7) will not change coverage.
The diff coverage is 11.11%.

@@           Coverage Diff           @@
##             main     #613   +/-   ##
=======================================
  Coverage   50.24%   50.24%           
=======================================
  Files          69       69           
  Lines        7314     7314           
=======================================
  Hits         3675     3675           
  Misses       3147     3147           
  Partials      492      492           
Files Changed Coverage Δ
api/converter/from_pb.go 47.77% <0.00%> (ø)
api/converter/to_pb.go 55.07% <0.00%> (ø)
client/client.go 13.48% <0.00%> (ø)
pkg/document/internal_document.go 13.67% <ø> (ø)
server/rpc/admin_server.go 53.97% <0.00%> (ø)
server/rpc/yorkie_server.go 56.82% <100.00%> (ø)

@hackerwins hackerwins added the protocol changed 📝 Whether the protocol has changed label Aug 18, 2023
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hackerwins hackerwins merged commit 54c926f into main Aug 18, 2023
1 check passed
@hackerwins hackerwins deleted the cleanup-docevent-proto branch August 18, 2023 03:48
Wu22e pushed a commit to Wu22e/yorkie that referenced this pull request Sep 3, 2023
* Change 'Documents' from plural to singular in DocEvent

* Add some comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol changed 📝 Whether the protocol has changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change 'Documents' from plural to singular in DocEvent
2 participants