Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in retention design document #633

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

LakHyeonKim
Copy link
Contributor

@LakHyeonKim LakHyeonKim commented Aug 31, 2023

What this PR does / why we need it:

Fix typo in retention.md

  • Figure describes a problem when deleting S3, not S2 therefore, modify S2 -> S3 on line 59.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

* The figure explains that there is a problem when deleting S3, not S2
@CLAassistant
Copy link

CLAassistant commented Aug 31, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b66068d) 49.40% compared to head (61ffe24) 49.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #633   +/-   ##
=======================================
  Coverage   49.40%   49.40%           
=======================================
  Files          69       69           
  Lines        9917     9917           
=======================================
  Hits         4899     4899           
  Misses       4504     4504           
  Partials      514      514           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins self-requested a review August 31, 2023 15:43
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit d0c265b into yorkie-team:main Aug 31, 2023
1 check passed
hackerwins pushed a commit that referenced this pull request Oct 1, 2023
* The figure explains that there is a problem when deleting S3, not S2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants