feat(auth): reexport token_source && rename internal TokenSource #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshidan
reviewed
Apr 11, 2025
1. reexport token_source::{TokenSource,TokenSourceProvider} in gcloud_auth::token.
2. rename gcloud::token::token_source::TokenSource to gcloud::token::token_source:: GoogleCloudTokenSource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
TokenSourceis confusing. At first I thought it'sgcloud_auth::token_source::TokenSource, but then I found it's actuallytoken_source::TokenSource.And for the example, we already delete the
foundation/tokenand I need to manually addtoken_sourcedependency anduse token_source::TokenSourceProvider.