Skip to content

Conversation

@dario-oai
Copy link

@dario-oai dario-oai commented Nov 15, 2025

  • We are using the SpannerClient at scale in production and wanted more insights into some of the internal metrics to ensure things are running smoothly and understand which config knobs to tweak if needed
  • I have confirmed metric emissions for most cases, but would still need to check get session timeout
  • The otel-metrics feature cfg enablement is pretty verbose, but not sure if this should be opt in with a feature flag or as a default. I could refactor to make it less verbose, but if it's okay to add opentelemetry as a dependency, most of the code could be removed. Please let me know your preference
    • I can add doc strings after deciding how this should be added
  • Use the Go library implementation as reference

@dario-oai dario-oai changed the title add otel-metrics to spanner Add OpenTelemetry based metrics to Spanner client Nov 17, 2025
@dario-oai dario-oai marked this pull request as ready for review November 17, 2025 23:53
@yoshidan yoshidan added the safe to test safe to test label Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test safe to test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants