Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sepc into &spec in test_{outside,inside}_containe #3068

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make sepc into &spec in test_{outside,inside}_containe #3068

wants to merge 1 commit into from
+75 −75

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Feb 8, 2025

Description

We don't need to pass spec.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Other (please describe):

Testing

  • Added new unit tests
  • Added new integration tests
  • Ran existing test suite
  • Tested manually (please provide steps)

Related Issues

None

Additional Context

@utam0k
Make sepc into &spec in test_{outside,inside}_containe
d8f3e5c 
Signed-off-by: utam0k <k0ma@utam0k.jp>
@utam0k utam0k requested a review from a team February 8, 2025 12:35
@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 8, 2025
@utam0k utam0k mentioned this pull request Feb 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@utam0k