* say async play #26
Closed
* say async play #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* UI not blocking
youknowone
requested changes
Sep 25, 2016
| @@ -57,6 +57,8 @@ class ViewController: NSViewController { | |||
| let voiceSavePanel = NSSavePanel() | |||
| /// Open panel for "Open" menu | |||
| let textOpenPanel = NSOpenPanel() | |||
|
|
|||
| var sayObj: Say! = nil; | |||
There was a problem hiding this comment.
I think instance variable is not nessessary here. Swift will capture the variable into the dispatch queue blocks.
youknowone
reviewed
Sep 25, 2016
| @@ -92,10 +94,22 @@ class ViewController: NSViewController { | |||
|
|
|||
| @IBAction func say(_ sender: NSControl) { | |||
| sender.isEnabled = false | |||
| Say(text: self.textForSpeech, voice: self.selectedVoice).play(true) | |||
| sender.isEnabled = true | |||
| self.sayObj = Say(text: self.textForSpeech, voice: self.selectedVoice) | |||
There was a problem hiding this comment.
Consider to use local variable say instead of self.sayObj.
Generally in apple environment, we don't like to use abbr like 'Obj'.
|
This patch is perfect except for the naming and scope issues. Thanks for nice work. |
added 2 commits
September 26, 2016 23:17
…_play # Conflicts: # Say/ViewController.swift
|
I am sorry but now it is fixed in other patches. Will you check it? |
|
I close this pull request |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Play the Say UI not blocking
Turned to the play async say
issue : #2
@youknowone