iOS Control Rate feature. (#42) #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 29, 2016 15:43
Added rate property to Speaker.
Added rateLabel to show rate value.
eeneguee
reviewed
Sep 29, 2016
| @@ -69,6 +70,12 @@ class ViewController: UIViewController, SpeakerDelegate, UIPickerViewDelegate, U | |||
| present(alertController, animated: true, completion: nil) | |||
| } | |||
|
|
|||
| @IBAction func rateChanged(_ sender: UISlider) { | |||
| let value = roundf(100 * sender.value) / 100 | |||
There was a problem hiding this comment.
When to display the quickness, natural number expression is usually used.
How about divide the speed level about 10 steps?
There was a problem hiding this comment.
Thank you for reviewing @eeneguee !. I tried to divided it into 10 levels but it didn't look natural... 😢 The rate was changed too much.
|
I like this feature. I want to discuss about user experience. |
|
@youknowone That's cool! I'll do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed iOS Control Rate feature. (issue #42 )
UISliderto control raterateproperty toSpeaker.rateLabelto show rate value.p.s - In this version, it shows its rate value
from 0.0 to 1.0.I think there's some better idea than mine. If you have, please reply it.