Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update bindgen to latest version #19

Merged
merged 1 commit into from
May 13, 2024

Conversation

Pranav2612000
Copy link
Contributor

@Pranav2612000 Pranav2612000 commented May 13, 2024

Fixes #18

Copy link
Owner

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@youknowone youknowone merged commit b7687e0 into youknowone:main May 13, 2024
33 of 346 checks passed
@Pranav2612000
Copy link
Contributor Author

Thank you for merging the PR @youknowone

I observed that some pipelines were failing in the PR – although I'm not sure how my change affected them.

Should the failures be looked into? Is it fine to merge with the failing pipeline?

@youknowone
Copy link
Owner

That probably is not affected by this patch, but by macOS SDK changes. I think it was already broken before this patch. Don't worry about it.

Still looking in it to fix them will be great though 😄

@Pranav2612000
Copy link
Contributor Author

That probably is not affected by this patch, but by macOS SDK changes. I think it was already broken before this patch. Don't worry about it.

Still looking in it to fix them will be great though 😄

Great! Thank you for the clarification @youknowone I'll see if I'm able to fix the broken pipelines.

Can you also help with making a release with this change? We need it for an app I'm working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build for intel mac architecture
2 participants