Skip to content

Corrected LeaveOpen bug on parser. Use CsvConfiguration object inste… #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rkramer1964 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Corrected LeaveOpen bug on parser. Use CsvConfiguration object inste… #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3708ce
Corrected LeaveOpen bug on parser. Use CsvConfiguration object inste…
Apr 13, 2023
5bb3be8
Fix codacy complaint
Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CsvHelper.Excel/CsvHelper.Excel.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<Description>An implementation of ICsvParser and ICsvSerializer from CsvHelper that reads and writes using the ClosedXml library.</Description>
<AssemblyTitle>CsvHelper for Excel</AssemblyTitle>
<VersionPrefix>27.2.1</VersionPrefix>
<VersionPrefix>27.2.2</VersionPrefix>
<Authors>Chris Young</Authors>
<TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>
<DebugType>portable</DebugType>
Expand Down
6 changes: 6 additions & 0 deletions src/CsvHelper.Excel/CsvHelper.Excel.csproj.user
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<_LastSelectedProfileId>C:\Users\rkramer\source\repos\rkramer1964\CsvHelper.Excel\src\CsvHelper.Excel\Properties\PublishProfiles\FolderProfile.pubxml</_LastSelectedProfileId>
</PropertyGroup>
</Project>
5 changes: 4 additions & 1 deletion src/CsvHelper.Excel/ExcelParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,10 @@ public ExcelParser(Stream stream, string sheetName, CsvConfiguration configurati
}

Context = new CsvContext(this);
_leaveOpen = Configuration.LeaveOpen;
if (configuration != null)
{
_leaveOpen = configuration.LeaveOpen; // use the csvconfiguration instead of the IParserConfiguration interface as LeaveOpen was removed in CsvHelper 30.0.0
}
}


Expand Down
14 changes: 14 additions & 0 deletions src/CsvHelper.Excel/Properties/PublishProfiles/FolderProfile.pubxml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="utf-8"?>
<!--
https://go.microsoft.com/fwlink/?LinkID=208121.
-->
<Project>
<PropertyGroup>
<Configuration>Release</Configuration>
<Platform>Any CPU</Platform>
<PublishDir>bin\Release\netstandard2.0\publish\</PublishDir>
<PublishProtocol>FileSystem</PublishProtocol>
<_TargetId>Folder</_TargetId>
<TargetFramework>netstandard2.0</TargetFramework>
</PropertyGroup>
</Project>
10 changes: 10 additions & 0 deletions src/CsvHelper.Excel/Properties/PublishProfiles/FolderProfile.pubxml.user
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="utf-8"?>
<!--
https://go.microsoft.com/fwlink/?LinkID=208121.
-->
<Project>
<PropertyGroup>
<History>True|2023-04-12T20:07:47.8368790Z;True|2023-04-12T15:07:35.6608090-05:00;False|2023-04-12T15:05:06.1012503-05:00;</History>
<LastFailureDetails />
</PropertyGroup>
</Project>