feat: Update CsvHelper to v31.0.3 and ClosedXml to v0.102.2#48
Open
hurles wants to merge 12 commits intoyoungcm2:mainfrom
Open
feat: Update CsvHelper to v31.0.3 and ClosedXml to v0.102.2#48hurles wants to merge 12 commits intoyoungcm2:mainfrom
hurles wants to merge 12 commits intoyoungcm2:mainfrom
Conversation
Update CsvHelper to v30.0.1 and ClosedXml to v0.101.0
chore: updated package info
tianxu0836
reviewed
Feb 6, 2024
| public ExcelParser(Stream stream, string sheetName, CsvConfiguration configuration, bool leaveOpen = false) | ||
| { | ||
| var workbook = new XLWorkbook(stream, XLEventTracking.Disabled); | ||
| var workbook = new XLWorkbook(stream); |
There was a problem hiding this comment.
In the input file is not an Excel file, but csv file. it will throw an exception
I thought the orignal idea was to support both csv and excel
Author
There was a problem hiding this comment.
The original would have thrown an exception there as well.
This issue is probably better suited for a different PR. This PR merely updates the ClosedXml and CsvHelper libraries, with fixes to some breaking changes.
tianxu0836
approved these changes
Feb 6, 2024
tianxu0836
left a comment
tianxu0836
left a comment
There was a problem hiding this comment.
The code works
The input has to be an excel file
Need to upgrade the libaries version again
upgrade CsvHelper from 30.0.1 to 31.0.3 upgrade testing libraries
hurles
changed the title
Author
I've updated the libraries to their latest version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is