🐛 fix: install XcodeGen bundled resources#3
Merged
younke merged 1 commit intoyounke:masterfrom Jan 17, 2026
Merged
Conversation
XcodeGen releases include runtime resources (e.g. share/xcodegen / XcodeGen_XcodeGenKit.bundle). Copy the full extracted archive into the asdf install prefix instead of only bin/xcodegen, and fail fast if resources are missing.
Owner
|
@gaelfoppolo lgtm, ty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a regression where the plugin installs only the
xcodegenexecutable but omits XcodeGen’s bundled runtime resources (e.g.share/xcodegenand/orXcodeGen_XcodeGenKit.bundle).When those resources are missing,
xcodegen generateprints messages like:No "base" settings foundNo "release config" settings foundNo "debug config" settings foundNo "iOS" settings found…and the generated
.xcodeprojcan end up with incomplete/empty build settings (e.g.SWIFT_VERSIONmissing) which then breaks downstreamxcodebuildruns.Root cause
The current
install_version()implementation copies only:${ASDF_DOWNLOAD_PATH}/bin/xcodegenBut XcodeGen releases are not “single binary only”; they ship additional resources required at runtime.
Fix
ASDF_INSTALL_PATH), not justbin/xcodegen.share/xcodegenorXcodeGen_XcodeGenKit.bundle).How to validate