Allowances for localhost not resolving

youtube · Feb 6, 2025 · d7daab3 · d7daab3
1 parent 4a1e681
commit d7daab3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/starboard/android/shared/test_filters.py b/starboard/android/shared/test_filters.py
@@ -54,6 +54,7 @@
         # This test is failing because localhost is not defined for IPv6 in
         # /etc/hosts.
         'SbSocketAddressTypes/SbSocketResolveTest.Localhost/filter_ipv6_type_ipv6',
+        'PosixSocketHints/PosixSocketResolveTest.Localhost/family_inet6_*',
 
         # SbDirectory has problems with empty Asset dirs.
         'SbDirectoryCanOpenTest.SunnyDayStaticContent',

diff --git a/starboard/nplb/posix_compliance/posix_socket_resolve_test.cc b/starboard/nplb/posix_compliance/posix_socket_resolve_test.cc
@@ -213,8 +213,9 @@ TEST_P(PosixSocketResolveTest, Localhost) {
 
   int result = getaddrinfo(kLocalhost, 0, &hints, &ai);
 #if SB_API_VERSION < 16
-  if (result == EAI_BADFLAGS && GetAddressFamily() == AF_INET6) {
-    // It's ok to return EAI_BADFLAGS for IPv6 on Starboard < 16.
+  if ((result == EAI_BADFLAGS || result == EAI_NODATA) &&
+      GetAddressFamily() == AF_INET6) {
+    // It's ok to return EAI_BADFLAGS or EAI_NODATA for IPv6 on Starboard < 16.
     freeaddrinfo(ai);
     return;
   }