[media] Implement SbPlayer based video playback #4283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomings
force-pushed
the
sbplayer_integration
branch
from
efda9a1 to
f37d4c6
Compare
xiaomings
force-pushed
the
sbplayer_integration
branch
18 times, most recently
from
f4793d7 to
47b83fd
Compare
xiaomings
force-pushed
the
sbplayer_integration
branch
4 times, most recently
from
4f77248 to
d2ca6ff
Compare
xiaomings
requested review from
briantting and
borongc
and removed request for
briantting
borongc
reviewed
Oct 30, 2024
third_party/blink/renderer/platform/media/web_media_player_impl.cc
Outdated
Show resolved
Hide resolved
borongc
reviewed
Oct 30, 2024
borongc
reviewed
Oct 30, 2024
borongc
reviewed
Oct 30, 2024
borongc
reviewed
Oct 30, 2024
xiaomings
force-pushed
the
sbplayer_integration
branch
3 times, most recently
from
9a07cfd to
3e56903
Compare
xiaomings
force-pushed
the
sbplayer_integration
branch
2 times, most recently
from
75a5a7d to
ab0fc0d
Compare
jasonzhangxx
approved these changes
Oct 30, 2024
xiaomings
force-pushed
the
sbplayer_integration
branch
from
ab0fc0d to
46e2470
Compare
third_party/blink/renderer/platform/media/web_media_player_impl.cc
Outdated
Show resolved
Hide resolved
andrewsavage1
approved these changes
Oct 31, 2024
kaidokert
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
I'll proactively approve - @andrewsavage1 comments still pending
yell0wd0g
reviewed
Oct 31, 2024
yell0wd0g
reviewed
Oct 31, 2024
The implementation was based on SbPlayerPipeline, with many features disabled (e.g. suspend/resume, UMA metrics) or unimplemented. The former are tracked by feature macros in //media/starboard/BUILD.gn linked with tracking bugs, the latters are marked with TODOs with tracking bugs. It also 1. Removed support of old Starboard versions (e.g. the EnhancedAudio starboard extension). 2. Worked around for incomplete type in SbPlayerBridge::CallbackHelper (see b/375665361). b/328305706
xiaomings
force-pushed
the
sbplayer_integration
branch
from
46e2470 to
00c93cd
Compare
borongc
pushed a commit
that referenced
this pull request
Nov 27, 2024
The implementation was based on SbPlayerPipeline, with many features disabled (e.g. suspend/resume, UMA metrics) or unimplemented. The former are tracked by feature macros in //media/starboard/BUILD.gn linked with tracking bugs, the latters are marked with TODOs with tracking bugs. It also 1. Removed support of old Starboard versions (e.g. the EnhancedAudio starboard extension). 2. Worked around for incomplete type in SbPlayerBridge::CallbackHelper (see b/375665361). b/328305706
borongc
pushed a commit
that referenced
this pull request
Nov 27, 2024
The implementation was based on SbPlayerPipeline, with many features disabled (e.g. suspend/resume, UMA metrics) or unimplemented. The former are tracked by feature macros in //media/starboard/BUILD.gn linked with tracking bugs, the latters are marked with TODOs with tracking bugs. It also 1. Removed support of old Starboard versions (e.g. the EnhancedAudio starboard extension). 2. Worked around for incomplete type in SbPlayerBridge::CallbackHelper (see b/375665361). b/328305706
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation was based on SbPlayerPipeline, with many features disabled (e.g. suspend/resume, UMA metrics) or unimplemented. The former are tracked by feature macros in //media/starboard/BUILD.gn linked with tracking bugs, the latters are marked with TODOs with tracking bugs.
It also
b/328305706