Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build shared library binaries instead of executables for test targets #4771

Merged
merged 19 commits into from
Feb 5, 2025
Merged

Build shared library binaries instead of executables for test targets #4771

merged 19 commits into from
Feb 5, 2025

Conversation

niranjanyardi
Copy link
Contributor

b/389971583

@niranjanyardi niranjanyardi requested review from a team as code owners January 27, 2025 22:00
@niranjanyardi niranjanyardi marked this pull request as draft January 27, 2025 22:04
@niranjanyardi niranjanyardi removed the request for review from johnxwork January 27, 2025 22:04
@niranjanyardi niranjanyardi force-pushed the create_nplb_shared_lib branch 2 times, most recently from 51c5325 to fb5af42 Compare January 28, 2025 00:36
@niranjanyardi niranjanyardi force-pushed the create_nplb_shared_lib branch 2 times, most recently from 97d5807 to cb0c5f8 Compare January 28, 2025 23:51
@niranjanyardi niranjanyardi marked this pull request as ready for review January 28, 2025 23:59
@niranjanyardi niranjanyardi force-pushed the create_nplb_shared_lib branch from cb0c5f8 to 8705848 Compare January 29, 2025 22:41
oxve
oxve reviewed Jan 30, 2025
View reviewed changes
testing/test.gni Outdated Show resolved Hide resolved
@niranjanyardi niranjanyardi force-pushed the create_nplb_shared_lib branch 3 times, most recently from 473d2e2 to 226e999 Compare February 4, 2025 00:13
@niranjanyardi niranjanyardi requested a review from oxve February 4, 2025 01:14
@niranjanyardi niranjanyardi force-pushed the create_nplb_shared_lib branch from 226e999 to 5587a0e Compare February 4, 2025 20:01
@niranjanyardi
Copy link
Contributor Author

FYI: I'm breaking out the test build and run changes.

This PR builds all tests as shared libraries, the next PR makes them run #4833

@niranjanyardi niranjanyardi marked this pull request as draft February 4, 2025 20:03
@niranjanyardi niranjanyardi force-pushed the create_nplb_shared_lib branch 4 times, most recently from fa911c6 to 7f391ce Compare February 4, 2025 23:28
@niranjanyardi niranjanyardi marked this pull request as ready for review February 4, 2025 23:31
@niranjanyardi niranjanyardi marked this pull request as draft February 4, 2025 23:40
@niranjanyardi niranjanyardi force-pushed the create_nplb_shared_lib branch from daa7fe6 to a0b4516 Compare February 4, 2025 23:56
@niranjanyardi niranjanyardi marked this pull request as ready for review February 5, 2025 00:00
@niranjanyardi niranjanyardi force-pushed the create_nplb_shared_lib branch from a0b4516 to 3520e01 Compare February 5, 2025 00:01
@niranjanyardi niranjanyardi force-pushed the create_nplb_shared_lib branch from 3520e01 to f373d15 Compare February 5, 2025 00:03
andrewsavage1
andrewsavage1 approved these changes Feb 5, 2025
View reviewed changes
cobalt/build/testing/cobalt_test_templates.gni Outdated Show resolved Hide resolved
device/bluetooth/BUILD.gn Outdated Show resolved Hide resolved
testing/test.gni Show resolved Hide resolved
build/config/gcc/BUILD.gn Outdated Show resolved Hide resolved
@niranjanyardi niranjanyardi enabled auto-merge (squash) February 5, 2025 00:50
@niranjanyardi niranjanyardi merged commit b21b278 into youtube:main Feb 5, 2025
96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y4vor y4vor y4vor approved these changes

@andrewsavage1 andrewsavage1 andrewsavage1 approved these changes

@oxve oxve Awaiting requested review from oxve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niranjanyardi @oxve @y4vor @andrewsavage1