[UWP] Prefere 60Hz display mode instead of 120Hz #4798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekLuxoft
commented
Jan 30, 2025
Comment on lines
+1024
to
+1026
| preferred_display_mode_hdmi_ = preferred_display_mode_sdr_ | ||
| ? preferred_display_mode_sdr_ | ||
| : preferred_display_mode_hdmi_; |
There was a problem hiding this comment.
In theory if we change display mode, we should also set new currently mode:
SetCurrentDisplayMode
but we change on the same resolution, so I didn't observe any side effect of those changes (and omitting SetCurrentDisplayMode)
| if (preferred_display_mode_hdmi_->RefreshRate > kRefreshRateMaximum && | ||
| (!preferred_display_mode_sdr_ || | ||
| preferred_display_mode_sdr_->RefreshRate < mode->RefreshRate)) { | ||
| preferred_display_mode_sdr_ = mode; |
There was a problem hiding this comment.
In theory it could happen that we don't find any different mode so preferred_display_mode_hdmi_ would have 120Hz on the end anyways but in practice, I think it's not possible (if device support 120Hz it should also support 60Hz).
to cover it we would need use 60Hz as a default refresh rate:
https://github.com/youtube/cobalt/blob/25.lts.1%2B/starboard/shared/uwp/application_uwp.h#L145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason of this pull request is huge number of dropped frames on XBOX for 120Hz.
During the investigation we observed strange behavior of Present1 method. It’s always takes ~15ms, but we believe that for 120Hz display it should be ~7ms (SyncInterval is set to 1).
After discussion with Microsoft Support it occur that 120Hz is not supported in UWP apps even though the app can select 120Hz display mode. It's recommended that UWPs should not select 120Hz display mode.
Tests:
PR was tested on Xbox Series S: