Increase pread() offset range to fix symbolization on 32-bit systems #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows reading symbols from libraries loaded above the 0x7fffffff address. b/299486087
kaidokert
reviewed
Feb 9, 2025
| @@ -52,6 +52,9 @@ | |||
| #include GLOG_BUILD_CONFIG_INCLUDE | |||
| #endif // GLOG_BUILD_CONFIG_INCLUDE | |||
|
|
|||
| // Allow pread() to use higher offsets on 32-bit systems. | |||
| #define _FILE_OFFSET_BITS 64 | |||
There was a problem hiding this comment.
Thank you for sending this fix.
If this helps fixing the issue - great.
However, i would assume that this is a define missing from a Starboard central configuration headers somewhere ? If it impacts the code in this file, i'd expect it would impact code elsewhere too.
@hlwarriner wdyt ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows reading symbols from libraries loaded above the 0x7fffffff address.
b/299486087