Re-add MediaSession java source code #4838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongqiliang
reviewed
Feb 4, 2025
There was a problem hiding this comment.
I did the same change a while ago, #4392, see john's comment, and Kaido had some opinions, check with them to see if they still want to use the Chromium 's infrastructure.
jasonzhangxx
force-pushed
the
media-session
branch
2 times, most recently
from
0d162c2 to
1372ef9
Compare
1. Re-wrote CobaltMediaSession to make it work with Chromium MediaSession. 2. Added necessary dependency lib. 3. Remove audio focus code from CobaltMediaSession as it's already handled by AudioFocusDelegate. 4. Still keep LifecycleCallback in CobaltMediaSession with a TODO. b/377019873
jasonzhangxx
force-pushed
the
media-session
branch
from
1372ef9 to
87a8d91
Compare
johnxwork
reviewed
Feb 14, 2025
cobalt/android/apk/app/src/main/java/dev/cobalt/coat/CobaltMediaSession.java
Show resolved
Hide resolved
johnxwork
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MediaSession.
handled by AudioFocusDelegate.
b/377019873