Remove dead special case for defunct branch COBALT #4850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove currently unsupported release packaging builds (evergreen) and simplify logic for supported release packaging builds. Remove deprecated code to improve readability. b/393447640
The required files were manually determined. This moves the release packging logic to the builder side rather than the snapshot side allowing better developer access and maintaince. b/393447640
… and inline local variable gcs_path_suffix. Issue: 365150653 Reviewed-on: youtube#4850
Copy chromecast::media::VideoGeometrySetterService to Cobalt folder, as this is needed for youtube#4810. The PR doesn't have any functional changes. b/391938746
The required files were manually determined. This moves the release packging logic to the builder side rather than the snapshot side allowing better developer access and maintaince. b/393447640
Create new matrix job for each test target that prints the logs and handles results per target. b/354062546
Remove currently unsupported release packaging builds (evergreen) and simplify logic for supported release packaging builds by removing redundant function "create_and_upload_nightly_archive". Remove deprecated code "simple_packager" to improve readability. b/393447640
b/393160172 Set is_starboard = false globally and true for linux based cobalt and starboard toolchains. Remove current toolchain info from is_cobalt_hermetic_build which makes it easier to be replaced by is_starboard
oxve
approved these changes
Feb 5, 2025
…ain args (youtube#4852) b/393160172 Make is_cobalt_hermetic_build a global variable so that it can be easily replaced by is_starboard and we can avoid some unnecessary includes
… and inline local variable gcs_path_suffix. Issue: 365150653
kaidokert
pushed a commit
to kaidokert/cobalt
that referenced
this pull request
Jun 15, 2025
… and inline local variable gcs_path_suffix. Issue: 365150653
briantting
pushed a commit
that referenced
this pull request
Jul 1, 2025
… and inline local variable gcs_path_suffix. Issue: 365150653 original-hexsha: 6d680b8
briantting
pushed a commit
that referenced
this pull request
Jul 11, 2025
… and inline local variable gcs_path_suffix. Issue: 365150653 original-hexsha: 6d680b8
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Jul 25, 2025
… and inline local variable gcs_path_suffix. Issue: 365150653 original-hexsha: 6d680b8
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Jul 26, 2025
… and inline local variable gcs_path_suffix. Issue: 365150653 original-hexsha: 6d680b8
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Jul 30, 2025
… and inline local variable gcs_path_suffix. Issue: 365150653 original-hexsha: 6d680b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and inline local variable gcs_path_suffix.
Issue: 365150653