Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ScheduleJobDuringShutdown test #4864

Open
wants to merge 1 commit into
base: 25.lts.1+
Choose a base branch
from

Conversation

alexanderbobrovnik
Copy link
Collaborator

Adds test to check that proper handling of JobThread shutdown. In current form this test should fail, because std::unique_ptr is not suitable to hold JobThread.

b/372515171

Adds test to check that proper handling of JobThread shutdown.
In current form this test should fail, because std::unique_ptr is
not suitable to hold JobThread.

b/372515171
Copy link
Contributor

@sideb0ard sideb0ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@amurovanyi
Copy link
Collaborator

@sideb0ard, please merge this PR, because we don't have corresponding rights.
Thank you!

@sideb0ard
Copy link
Contributor

@sideb0ard, please merge this PR, because we don't have corresponding rights. Thank you!

hi!
I left a comment on #4275
as this now breaks the build (as expected), let's copy the test to #4275, which should now pass. Once we have #4275 merged, we can abandon this change. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants