Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip cobalt binary #4865

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Strip cobalt binary #4865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cobalt/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import("//build/linux/strip_binary.gni")
import("//testing/test.gni")

group("gn_all") {
Expand All @@ -23,7 +24,7 @@ group("gn_all") {
"//starboard/nplb",
]
if (!is_android) {
deps += [ ":cobalt" ]
deps += [ ":strip_cobalt_binary" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be a dep of the cobalt target instead?

} else {
# TODO(cobalt): reuse build rules below to define Android target.
deps += [ "android:cobalt_apk" ]
Expand Down Expand Up @@ -65,6 +66,12 @@ if (!is_android) {

configs += [ "//build/config/gcc:rpath_for_built_shared_libraries" ]
}

strip_binary("strip_cobalt_binary") {
binary_input = "$root_out_dir/cobalt"
deps = [ ":cobalt" ]
testonly = true
}
}

action("cobalt_build_info") {
Expand Down
Loading