Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): #160 Kotlin 2.0 and fixed Issue With New Compiler Options DSL #162

Merged
merged 1 commit into from
Aug 31, 2024
Merged

fix(deps): #160 Kotlin 2.0 and fixed Issue With New Compiler Options DSL #162

merged 1 commit into from
Aug 31, 2024
+9 −6

Conversation

iammohdzaki
Copy link
Contributor

@iammohdzaki iammohdzaki commented Aug 8, 2024 •
edited by yshrsmz
Loading

resolve #160

@iammohdzaki iammohdzaki changed the title Kotlin 2.0 Migration and Fixed Issue With New Compiler Options DSL #160 fix(deps): #160 Fixed Issue With New Compiler Options DSL Aug 8, 2024
@iammohdzaki iammohdzaki mentioned this pull request Aug 8, 2024
Closed
yshrsmz
yshrsmz requested changes Aug 12, 2024
View reviewed changes
Copy link
Owner

@yshrsmz yshrsmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Can you check if other modules need the same update?

gradle/libs.versions.toml Outdated
@@ -1,6 +1,6 @@
[versions]
gradle = "8.2.1"
kotlin = "1.9.22"
kotlin = "2.0.0"
dokka = "1.9.20"
android = "8.1.1"
jvmTarget = "1.8"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use this value instead of JvmTarget.JVM_1_8?
This way, we can update all the places at the same time when needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
Actually the problem is they have moved from String definition to enum definition for JVM Target. We have to use enum value. I don't see a way to define enum type in libs.version.toml

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks.

Then, can you update other places using this value(like here: https://github.com/yshrsmz/BuildKonfig/blob/master/buildkonfig-compiler/build.gradle.kts#L44) and remove this jvmTarget ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I updated compiler options in the buildKonfig-compiler module.

yshrsmz
yshrsmz approved these changes Aug 31, 2024
View reviewed changes
Copy link
Owner

@yshrsmz yshrsmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
I'll make a new release asap ;)

@yshrsmz yshrsmz merged commit 4655ce3 into yshrsmz:master Aug 31, 2024
2 checks passed
@yshrsmz yshrsmz changed the title fix(deps): #160 Fixed Issue With New Compiler Options DSL fix(deps): #160 Kotlin 2.0 and fixed Issue With New Compiler Options DSL Aug 31, 2024
This was referenced Jul 20, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshrsmz yshrsmz yshrsmz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue With New Compiler Options DSL
2 participants
@iammohdzaki @yshrsmz