Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for numpy<1.19 #403

Merged
merged 2 commits into from
Apr 1, 2023
Merged

Drop support for numpy<1.19 #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ec3645
Drop support for numpy<1.19
neutrinoceros Apr 1, 2023
fa58b77
DOC: add missing mention of dask in dev guide
neutrinoceros Apr 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ These enable testing the docstrings and doctest examples scattered throughout
the unyt and its documentation.

You will need to install ``pytest`` and ``pytest-doctestplus`` to run this
command. Some tests depend on ``h5py``, ``Pint``, ``astropy`` and ``matplotlib``
command. Some tests depend on ``h5py``, ``Pint``, ``astropy``, ``matplotlib`` and ``dask``
being installed.

If you would like to run the tests on multiple python versions, first ensure
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ keywords = [
]
requires-python = ">=3.8"
dependencies = [
"numpy>=1.17.5",
"numpy>=1.19",
"sympy>=1.5",
]
dynamic = [
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ deps =
docutils
pytest
sympy==1.5
numpy==1.17.5
numpy==1.19.0
h5py==3.0.0
pint==0.9
astropy==3.2.3
Expand Down
13 changes: 0 additions & 13 deletions unyt/tests/test_array_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
# tests for NumPy __array_function__ support
import re
from importlib.metadata import version

import numpy as np
import pytest
from packaging.version import Version

from unyt import A, K, cm, degC, degF, delta_degC, g, km, rad, s
from unyt._array_functions import (
Expand All @@ -20,7 +18,6 @@
)
from unyt.testing import assert_array_equal_units

NUMPY_VERSION = Version(version("numpy"))
# this is a subset of NOT_HANDLED_FUNCTIONS for which there's nothing to do
# because they don't apply to (real) numeric types
# or they work as expected out of the box
Expand Down Expand Up @@ -862,9 +859,6 @@ def test_copy():
assert type(y) is np.ndarray


@pytest.mark.skipif(
NUMPY_VERSION < Version("1.19"), reason="np.copy's subok arg requires numpy 1.19+"
)
def test_copy_subok():
x = [1, 2, 3] * cm
y = np.copy(x, subok=True)
Expand Down Expand Up @@ -1587,13 +1581,6 @@ def test_triangles(func):
assert res.units == cm


@pytest.mark.skipif(
NUMPY_VERSION < Version("1.19"),
reason=(
"einsum raises a spurious TypeError with out=None and optimize=False "
"(which are default values)"
),
)
def test_einsum():
a = np.eye(4) * cm

Expand Down