Do not use tokens for Pypi uploads #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/wheels.yaml
Outdated
| @@ -63,6 +63,11 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| # upload to PyPI on every tag starting with 'yt_astro_analysis-' | |||
| if: github.event_name == 'push' && startsWith(github.event.ref, 'refs/tags/yt_astro_analysis-') | |||
| environment: | |||
| name: pypi | |||
There was a problem hiding this comment.
from the email I got when trusted-publishing was enabled on PyPI:
Environment: upload_pypi
The same name should be used here (but you could also change it on PyPI if you haven't already)
There was a problem hiding this comment.
Note that you'll also need to actually create the env on the repo's side
|
Looks good to me, to the extent that I know much about this. Do you want to try and test it out on test.pypi? |
brittonsmith
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
@cphyc approval from me, but I think you should merge it in case you want to see what happens when you do.
cphyc
force-pushed
the
upgrade-pypi-credentials
branch
from
2427f94
to
ad2d8ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the need to use a token to upload to Pypi. Instead, one configures the project on Pypi to accept authentication from GitHub (https://pypi.org/manage/project/yt-astro-analysis/settings/publishing/).
This should allow us to completely remove the need for authorization tokens in the secrets.