subtitles: remember category rework #4402
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I needed a way to enable subtitles for all channel regardless of the channel watched, and since I couldn't find a way in the settings I added it.
I replaced the "Remember enabled subtitles per each channel" switch with a new category called "Remember enabled subtitles" with the following options: "Do not remember", "Remember for each channel", "Remember globally". The logic for the first two options should be the same as before, but the new third option ignores the enabled subtitles channels and shows the subtitles at all times.
It should be almost ready to merge, but there's a couple things that should be kept in mind:
Thank you for reading and let me know if there are any issues