Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to select us-letter with correct margins #79

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

MaikRe
Copy link
Contributor

@MaikRe MaikRe commented Jan 16, 2025

Fixes #75

@yunanwg
Copy link
Owner

yunanwg commented Jan 20, 2025

Hi @alexk101 sorry for the late reaction, I've been quite busy recently.

Will take a look later today!

@yunanwg yunanwg self-assigned this Jan 20, 2025
Copy link
Owner

@yunanwg yunanwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add a new variable in metadata.toml, with a comment to state what does it do, and it being optional?

lib.typ Outdated Show resolved Hide resolved
@yunanwg yunanwg merged commit 7ebaeb4 into yunanwg:main Jan 21, 2025
1 check passed
@yunanwg
Copy link
Owner

yunanwg commented Jan 21, 2025

LGTM, thanks a lot @MaikRe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add page size configuration between a4 and us-letter
2 participants