fix(monitor): add service metric monitor #22226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swordqiu
requested changes
Mar 8, 2025
pkg/cloudmon/misc/system.go
Outdated
| params.Set("limit", jsonutils.NewInt(20)) | ||
| params.Set("brand", jsonutils.NewString("OneCloud")) | ||
| params.Set("scope", jsonutils.NewString("system")) | ||
| params.Set("status", jsonutils.NewString("running")) |
swordqiu
requested changes
Mar 8, 2025
pkg/cloudmon/misc/system.go
Outdated
| return influxdb.SendMetrics(urls, SYSTEM_METRIC_DATABASE, metrics, false) | ||
| }() | ||
| if err != nil { | ||
| log.Errorf("collect service metric error: %v", err) | ||
| } | ||
| params := jsonutils.NewDict() |
There was a problem hiding this comment.
建议此处用 options.BaseListOptions，不要构造json
ioito
force-pushed
the
hotfix/qx-service-metric-monitor
branch
from
e9a8a09 to
554b4ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If yes, write the release branches name in the below format and submit the related cherry-pick PR: