Fix the need of staticlib target to have a build.rs customization
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvan-sraka
commented
Jan 10, 2023
iquerejeta
suggested changes
Jan 11, 2023
yvan-sraka
commented
Jan 17, 2023
yvan-sraka
commented
Jan 17, 2023
yvan-sraka
commented
Jan 17, 2023
yvan-sraka
force-pushed
the
staticlib-build.rs
branch
from
8631b16
to
b2c64a4
Compare
yvan-sraka
force-pushed
the
main
branch
3 times, most recently
from
3afcc6d
to
deb700b
Compare
KtorZ
added a commit
to CardanoSolutions/cardano-node
that referenced
this pull request
Sep 27, 2023
This is hopefully temporary until I figure out why GHC can't compile
cardano-node tests when relying on the 'cddl' package. At the moment,
it panics with:
```
<command line>: dlopen([...]/dist-newstyle/build/aarch64-osx/ghc-8.10.7/cddl-1.0.0/build/libHScddl-1.0.0-inplace-ghc8.10.7.dylib, 0x0005):
symbol not found in flat namespace '_CFRelease'
```
It could be similar to the issue describe here:
yvan-sraka/cargo-cabal#2; and a possible
work-around could be to build a dynamic library from Rust instead of
static one.
neilmayhew
pushed a commit
to CardanoSolutions/cardano-node
that referenced
this pull request
Nov 1, 2023
This is hopefully temporary until I figure out why GHC can't compile
cardano-node tests when relying on the 'cddl' package. At the moment,
it panics with:
```
<command line>: dlopen([...]/dist-newstyle/build/aarch64-osx/ghc-8.10.7/cddl-1.0.0/build/libHScddl-1.0.0-inplace-ghc8.10.7.dylib, 0x0005):
symbol not found in flat namespace '_CFRelease'
```
It could be similar to the issue describe here:
yvan-sraka/cargo-cabal#2; and a possible
work-around could be to build a dynamic library from Rust instead of
static one.
This intends to fix this GHC issue https://gitlab.haskell.org/ghc/ghc/-/issues/22564#note_469030
yvan-sraka
force-pushed
the
staticlib-build.rs
branch
from
b2c64a4
to
b9a71ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intends to fix this GHC issue https://gitlab.haskell.org/ghc/ghc/-/issues/22564#note_469030