Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix site-packages for Pythonista >= v3.4 #480

Merged
merged 1 commit into from
May 4, 2023
Merged

Fix site-packages for Pythonista >= v3.4 #480

merged 1 commit into from
May 4, 2023

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Apr 24, 2023 •
edited
Loading

Fixes: #462

        SITE_PACKAGES_DIR_NAME = "site-packages"
        if sys.version_info < (3, 10):  # Pythonista < v3.4
            SITE_PACKAGES_DIR_NAME += "-3"

@bennr01 @ywangd Your review, please.

@cclauss cclauss force-pushed the fix-site-packages-for-pythonista-v3.4 branch from 16828e5 to 436aa80 Compare April 24, 2023 14:26
This was referenced Apr 29, 2023
Closed
Closed
@cclauss cclauss requested review from fschaeck, ywangd and bennr01 May 4, 2023 13:54
@cclauss
Copy link
Collaborator Author

cclauss commented May 4, 2023

Partially fixed on dev in a882c80
Partially fixed on master in fbdb9cf

@cclauss cclauss force-pushed the fix-site-packages-for-pythonista-v3.4 branch from 3b31cc5 to e417089 Compare May 4, 2023 14:27
@cclauss cclauss merged commit ad15e2c into ywangd:dev May 4, 2023
@cclauss cclauss deleted the fix-site-packages-for-pythonista-v3.4 branch May 4, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschaeck fschaeck Awaiting requested review from fschaeck

@ywangd ywangd Awaiting requested review from ywangd

@bennr01 bennr01 Awaiting requested review from bennr01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cclauss