Add tests

yyoshiki41 · Nov 26, 2016 · 70a7006 · 70a7006
1 parent 87ab5b4
commit 70a7006
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 8 deletions.
diff --git a/client_test.go b/client_test.go
@@ -25,7 +25,7 @@ func TestEmptyHTTPClient(t *testing.T) {
 	client, err := New("")
 	if err == nil {
 		t.Errorf(
-			"Should detect HTTPClient is nil.\nclient: %v", client)
+			"Should detect that HTTPClient is nil.\nclient: %v", client)
 	}
 }
 
@@ -96,7 +96,7 @@ func TestNewRequestWithEmptyContext(t *testing.T) {
 	var ctx context.Context
 	_, err = client.newRequest(ctx, "GET", "", &Params{})
 	if err == nil {
-		t.Error("Should detect empty context.")
+		t.Error("Should detect an empty context.")
 	}
 }
 

diff --git a/m3u8_test.go b/m3u8_test.go
@@ -7,6 +7,6 @@ import (
 func TestGetChunklistFromM3U8(t *testing.T) {
 	_, err := GetChunklistFromM3U8("")
 	if err == nil {
-		t.Error("Should detect error.")
+		t.Error("Should detect an error.")
 	}
 }
diff --git a/program_test.go b/program_test.go
@@ -89,17 +89,17 @@ func TestGetProgramByStartTimeEmptyStationID(t *testing.T) {
 
 	_, err = c.GetProgramByStartTime(context.Background(), "", time.Now())
 	if err == nil {
-		t.Error("Should detect error.")
+		t.Error("Should detect an error.")
 	}
 }
 
 func TestGetWeeklyPrograms(t *testing.T) {
-	client, err := New("")
+	c, err := New("")
 	if err != nil {
 		t.Fatalf("Failed to construct client: %s", err)
 	}
 
-	programs, err := client.GetWeeklyPrograms(context.Background(), "LFR")
+	programs, err := c.GetWeeklyPrograms(context.Background(), "LFR")
 	if err != nil {
 		t.Error(err)
 	}

diff --git a/stream_test.go b/stream_test.go
@@ -19,6 +19,6 @@ func TestGetStreamMultiURL(t *testing.T) {
 func TestNotExistsStreamMultiURL(t *testing.T) {
 	_, err := GetStreamMultiURL("TEST_LFR")
 	if err == nil {
-		t.Error("Should detect error.")
+		t.Error("Should detect an error.")
 	}
 }
diff --git a/timeshift_test.go b/timeshift_test.go
@@ -1,6 +1,10 @@
 package radiko
 
-import "testing"
+import (
+	"context"
+	"testing"
+	"time"
+)
 
 func TestTimeshiftPlaylistM3U8(t *testing.T) {
 	if isOutsideJP() {
@@ -14,3 +18,15 @@ func TestTimeshiftPlaylistM3U8(t *testing.T) {
 
 	_ = client
 }
+
+func TestEmptyStationIDTimeshiftPlaylistM3U8(t *testing.T) {
+	client, err := New("")
+	if err != nil {
+		t.Fatalf("Failed to construct client: %s", err)
+	}
+
+	_, err := c.TimeshiftPlaylistM3U8(context.Background(), "", time.Now())
+	if err == nil {
+		t.Error("Should detect an error.")
+	}
+}