refactor(test): Use path/filepath pkg

auth_test.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"encoding/base64"
 	"os"
-	"path"
+	"path/filepath"
 	"testing"
 )
 
@@ -56,7 +56,7 @@ func TestAuth2Fms(t *testing.T) {
 		t.Error(err)
 	}
 
-	pngPath := path.Join(testdataDir, "authkey.png")
+	pngPath := filepath.Join(testdataDir, "authkey.png")
 	f, err := os.Open(pngPath)
 	if err != nil {
 		t.Error(err)

client_test.go

@@ -202,7 +202,7 @@ func TestSetUserAgent(t *testing.T) {
 	const expected = "test-user-agent"
 	SetUserAgent(expected)
 	if expected != userAgent {
-		t.Errorf("expected %d, but %d", expected, userAgent)
+		t.Errorf("expected %s, but %s", expected, userAgent)
 	}
 }
 

internal/m3u8/m3u8_test.go

@@ -3,7 +3,7 @@ package m3u8
 import (
 	"bufio"
 	"os"
-	"path"
+	"path/filepath"
 	"testing"
 )
 
@@ -14,7 +14,7 @@ func readTestData(fileName string) *os.File {
 	if GOPATH == "" {
 		panic("$GOPATH is empty.")
 	}
-	f, err := os.Open(path.Join(GOPATH, "src", testDir, fileName))
+	f, err := os.Open(filepath.Join(GOPATH, "src", testDir, fileName))
 	if err != nil {
 		panic(err)
 	}

player_test.go

@@ -1,15 +1,15 @@
 package radiko
 
 import (
-	"path"
+	"path/filepath"
 	"testing"
 )
 
 func TestDownloadPlayer(t *testing.T) {
 	dir, removeDir := createTestTempDir(t)
 	defer removeDir() // clean up
 
-	playerPath := path.Join(dir, "myplayer.swf")
+	playerPath := filepath.Join(dir, "myplayer.swf")
 	err := DownloadPlayer(playerPath)
 	if err != nil {
 		t.Errorf("Failed to download player.swf: %s", err)

program_test.go

@@ -3,7 +3,7 @@ package radiko
 import (
 	"context"
 	"os"
-	"path"
+	"path/filepath"
 	"testing"
 	"time"
 
@@ -109,7 +109,7 @@ func TestGetWeeklyPrograms(t *testing.T) {
 }
 
 func TestDecodeStationsData(t *testing.T) {
-	file, err := os.Open(path.Join(testdataDir, "stations.xml"))
+	file, err := os.Open(filepath.Join(testdataDir, "stations.xml"))
 	if err != nil {
 		t.Fatal(err)
 	}

testing.go

@@ -5,7 +5,7 @@ import (
 	"io/ioutil"
 	"net/http"
 	"os"
-	"path"
+	"path/filepath"
 	"testing"
 )
 
@@ -30,7 +30,7 @@ func init() {
 	if goPath == "" {
 		panic("$GOPATH is empty.")
 	}
-	testdataDir = path.Join(goPath, "src", "github.com/yyoshiki41/go-radiko", "testdata")
+	testdataDir = filepath.Join(goPath, "src", "github.com/yyoshiki41/go-radiko", "testdata")
 }
 
 // For skipping tests.