Remove deprecated fit_predict & fit_predict_score#617
Open
onixlas wants to merge 3 commits intoyzhao062:developmentfrom
Open
Remove deprecated fit_predict & fit_predict_score#617onixlas wants to merge 3 commits intoyzhao062:developmentfrom
onixlas wants to merge 3 commits intoyzhao062:developmentfrom
Conversation
Pull Request Test Coverage Report for Build 12478149249Details
💛 - Coveralls |
Contributor
Author
|
It looks like the deprecated fit_predict_score method is being overridden in the DevNet class. Perhaps it should be removed as well. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecated
fit_predict&fit_predict_scorefromBaseDetectorclass and all the corresponding tests. These methods were marked as deprecated in version 0.6.9 and were expected to be removed in version 0.8.0.All Submissions Basics:
All Submissions Cores: