Harden model_analysis_jsons package-data config and add sdist regression test#659
Harden model_analysis_jsons package-data config and add sdist regression test#659ReinerBRO wants to merge 2 commits intoyzhao062:masterfrom
Conversation
|
Hi @ReinerBRO, thanks for taking the time to look into this and for the regression test idea — that kind of guard is genuinely useful for packaging issues like this one. A heads-up on timing: we already landed a fix for #642 in commit ad0d103 (Feb 26), which corrected the With that in mind, a few notes on the changes here:
Would you be open to submitting a revised PR with just the test (with the above tweaks)? That would be a welcome addition. Thanks again for the contribution! |
Summary
model_analysis_jsonsare included via bothpyodandpyod.utilspackage paths insetup.pygraft pyod/utils/model_analysis_jsonsinMANIFEST.insdistand asserts JSON assets are present in the archiveWhy
Issue #642 reports missing
model_analysis_jsonsfiles in installed distributions, which breaks auto model selection at runtime.Validation
python3 -m pytest pyod/test/test_package_data.py -qpython3 -m py_compile setup.pyCloses #642