Don't treat trusted import as unknown type when referenced as struct member type#268
Merged
Zuhaitz-dev merged 1 commit intoz-libs:mainfrom Mar 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Marks trusted imports as external symbols so
--typecheckdoesn't outputUnknown type '%s' (assuming external C struct)when it doesn't have to assume.This brings the compiler in line with the README during typecheck but with zero warnings:
I reordered
validate_typesto avoid searchingfind_type_aliasif it found a struct by that name, and chose to putis_extern_symbolbeforeis_traitas I expect it to be a cheaper search for all projects (likefind_selective_import), but asis_traitis more likely to return a match I can swap them back around if desired.Type of change
Checklist: