add the option to set tags on karpenter EC2 instances per node pool

[tcondeixa]

add the option to set tags on karpenter EC2 instances per node pool

[tcondeixa]

Can you confirm this will not force the node rotation and only new nodes will have the new tags?

[mikkeloscar]

Can you confirm this will not force the node rotation and only new nodes will have the new tags?

99% sure that it does not trigger a rotation because we don't have drift enabled in Karpenter. We do some check in CLM to determine if rotation is needed but I don't think it checks for tags.

(I would confirm via a pet cluster :))

[tcondeixa]

Can you confirm this will not force the node rotation and only new nodes will have the new tags?

99% sure that it does not trigger a rotation because we don't have drift enabled in Karpenter. We do some check in CLM to determine if rotation is needed but I don't think it checks for tags.

(I would confirm via a pet cluster :))

I can also add one tag in one of the dev clusters after merge to see if the nodes are rotated. Or do you recommend to do it in pet cluster?

[zalando-robot]

Deployment Checklist

This change falls under the deployment policy.

💁 Since Nov 10th, we are in the RED deployment zone. This means all changes released to production must adhere to the following requirements:

• Detailed release notes are provided in this PR’s description.
• Thorough load-testing has been performed, and is documented in the description/comment.
• Technical review: Principal Engineers or Tech Leads have green-lit your changes, and the reviewer is named in the description/comments.
• You can enable/disable the change via feature toggles, and have confirmed these toggles work as expected.
• Application Owner (Director+) approval is given about the PR, and the approver is named in the description/comments.

👉 Regardless of which boxes you click in this comment, merge/deployment will not be blocked.
Reports about deployment policy adherence will be circulated daily for Cyber-Week-relevant applications.

[tcondeixa]

I tested this solution and the instances were tagged with the new tag without forcing the rotation of the instances by Karpenter.
This is ready to be merged after CW.