#329 handle no results

zalando-stups · Oct 27, 2015 · 38a2bf9 · 38a2bf9
1 parent f6a6a04
commit 38a2bf9
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 5 deletions.
diff --git a/client/lib/common/asset/less/common/datepicker.less b/client/lib/common/asset/less/common/datepicker.less
@@ -10,7 +10,7 @@
         outline: none;
         position: absolute;
         background: white;
-        z-index: 10;
+        z-index: 20;
         box-shadow: 0px 0px 10px @gray;
 
         .DayPicker-Month {

diff --git a/client/lib/common/asset/less/violation/violation-analysis.less b/client/lib/common/asset/less/violation/violation-analysis.less
@@ -1,5 +1,10 @@
 @import "../variables";
 
+.violation-analysis-empty {
+    text-align: center;
+    padding-top: @padding-small;
+}
+
 .violation-analysis {
     padding-top: @padding-small;
 

diff --git a/client/lib/violation/src/violation-analysis/violation-analysis.jsx b/client/lib/violation/src/violation-analysis/violation-analysis.jsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import Icon from 'react-fa';
 import moment from 'moment';
 import _ from 'lodash';
 import Charts from 'react-d3-components';
@@ -49,16 +50,18 @@ class ViolationAnalysis extends React.Component {
 
     render() {
         let searchParams = this.stores.fullstop.getSearchParams(),
-            violationCount = this.stores.fullstop
-                                .getViolationCount()
-                                .map(c => ({
+            violationCount = this.stores.fullstop.getViolationCount(),
+            chartData = [];
+
+        if (violationCount.length) {
+            violationCount = violationCount.map(c => ({
                                     type: c.type,
                                     typeHelp: this.stores.fullstop.getViolationType(c.type).help_text,
                                     typeSeverity: this.stores.fullstop.getViolationType(c.type).violation_severity,
                                     account: c.account,
                                     accountName: this.stores.team.getAccount(c.account).name,
                                     quantity: c.quantity
-                                })),
+                                }));
             chartData = violationCount.filter(c => c.account === searchParams.inspectedAccount);
 
         return <div className='violation-analysis'>
@@ -112,6 +115,12 @@ class ViolationAnalysis extends React.Component {
                         :
                         null}
                 </div>;
+        }
+
+        return <div className='violation-analysis-empty'>
+                    <div><Icon name='smile-o' size='4x' /></div>
+                    <span>No violations!</span>
+                </div>
     }
 }
 ViolationAnalysis.displayName = 'ViolationAnalysis';