Clarify retry semantics, fault types, and transient-fault-detection requirement#1845
Open
sri-adarsh-kumar wants to merge 2 commits intozalando:mainfrom
Open
Clarify retry semantics, fault types, and transient-fault-detection requirement#1845sri-adarsh-kumar wants to merge 2 commits intozalando:mainfrom
sri-adarsh-kumar wants to merge 2 commits intozalando:mainfrom
Conversation
…sed retries - Document that only safe/idempotent methods are retried on socket faults - Document that connection faults are retried for all methods when transient-fault-detection.enabled=true (request never reached server) - Document that response-based retries (e.g. 503) must be triggered explicitly via retry() route or RetryException - Add 503 retry example to riptide-failsafe README - Add retry semantics callout box to riptide-spring-boot-autoconfigure README - Add retry trigger table to docs/resilience.md Closes zalando#952 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Correct misleading claim that socket faults are retried automatically for idempotent methods without any extra config: this only applies when transient-fault-detection.enabled=true is also set - Add explicit plain statement: retry: config alone does not enable automatic transport-fault retries - Add 2-row behavior matrix in Spring Boot autoconfigure README - Expand trigger table in docs/resilience.md with a Condition column making the transient-fault-detection requirement explicit per row Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sri-adarsh-kumar
requested review from
Joyfolk,
cberg-zalando,
fatroom,
gpradeepkrishna and
lukasniemeier-zalando
as code owners
sri-adarsh-kumar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies retry semantics around idempotency, fault types, and response-based retries in riptide-failsafe and spring-boot-autoconfigure READs.
Fixes socket-fault retry docs to correctly require transient-fault-detection instead of being standalone.
Adds consolidated resilience docs overview at docs/resilience.md.
Closes #952