Properly handle Patroni bootstrap_labels config #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughcapet
force-pushed
the
patroni-bootstrap-labels
branch
from
8a53a6b to
c624ff8
Compare
hughcapet
force-pushed
the
patroni-bootstrap-labels
branch
2 times, most recently
from
f931584 to
928da9c
Compare
hughcapet
force-pushed
the
patroni-bootstrap-labels
branch
from
928da9c to
3cf6ecb
Compare
|
👍 |
macedigital
reviewed
Mar 7, 2025
Comment on lines
+798
to
+802
| try: | ||
| tags = json.loads(os.getenv('LOG_S3_TAGS')) | ||
| except (TypeError, ValueError) as e: | ||
| logging.warning("could not parse LOG_S3_TAGS as a JSON: %r, reverting to the default empty dict", e) | ||
| tags = {} |
There was a problem hiding this comment.
This is unrelated to the bootstrap-label changes, but makes a lot of sense to be more careful with parsing those strings.
|
👍 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuration of
patroni.kubernetes.bootstrap_labelsvia Spilo