Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable set the icons map #408

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Enable set the icons map #408

merged 2 commits into from
Aug 22, 2024

Conversation

mikicho
Copy link
Contributor

@mikicho mikicho commented Aug 17, 2024

I want to override the default icons to support custom blocks. I don't know if this is the best way to achieve this. Please let me know what you think.

Copy link

height bot commented Aug 17, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@m-Ryan
Copy link
Collaborator

m-Ryan commented Aug 19, 2024

#153

Our recommended way is to override the CSS corresponding to the class name.

@mikicho
Copy link
Contributor Author

mikicho commented Aug 19, 2024

I saw this issue. Why don't we want to expose the icon set map?

Comment on lines 40 to 44
}

export function setIconsMap(map: Record<string, string>) {
iconsMap = {...map};
}
Copy link
Collaborator

@m-Ryan m-Ryan Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export function setIconsMap(map: Record<string, string>) {
  iconsMap = {...iconsMap, ...map};
}

@m-Ryan
Copy link
Collaborator

m-Ryan commented Aug 20, 2024

I saw this issue. Why don't we want to expose the icon set map?

Doing it this way is also fine. For small PRs, I will bundle a few features together before releasing them, rather than releasing immediately.

@mikicho
Copy link
Contributor Author

mikicho commented Aug 20, 2024

Doing it this way is also fine. For small PRs, I will bundle a few features together before releasing them rather than releasing them immediately.

Sure! no rush, for now I'm using the css workaround

@mikicho mikicho requested a review from m-Ryan August 20, 2024 18:16
@m-Ryan m-Ryan merged commit 6308501 into zalify:master Aug 22, 2024
1 check passed
@mikicho mikicho deleted the patch-3 branch August 22, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants