Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts() Governor DAO #115

Merged
merged 15 commits into from
Sep 8, 2023
Merged

Contracts() Governor DAO #115

merged 15 commits into from
Sep 8, 2023

Conversation

immortal-tofu
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla-signed label Aug 29, 2023
@immortal-tofu immortal-tofu force-pushed the governor-dao branch 2 times, most recently from 5609b65 to 0067de7 Compare September 7, 2023 02:17
@immortal-tofu immortal-tofu changed the title WIP: Contracts() Governor DAO Contracts() Governor DAO Sep 7, 2023
@tremblaythibaultl
Copy link
Contributor

Good work!
Do you think it's worth adding tests that check that a winning proposal can get executed properly?

@immortal-tofu
Copy link
Collaborator Author

Yes clearly, I'll add that 👍

Copy link
Contributor

@tremblaythibaultl tremblaythibaultl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@immortal-tofu immortal-tofu merged commit 40d00d4 into main Sep 8, 2023
2 checks passed
@immortal-tofu immortal-tofu deleted the governor-dao branch September 8, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants