feat: new handle computation method #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In summary: when computing any handle (except for fheRand(Bounded) and user inputs inside verifyCiphertext) , in the preimage of the hash we append both the ACL address and chainID.
For fheRand(Bounded), we also take into account both of the ACL address and chainID, but we are also adding the timestamp (proportional to the slot) as well as the blockhash of the previous block in the preimage of the seed given to the OPRF - taking the first 16 bytes from the 32 bytes of the hash since the OPRF takes u128 inputs as seed. This seed is then also used in the preimage of the handle.
I guess for user inputs, the ZKPOK metadata should also include both of ACL address and chainID for consistency, wdyt @mortendahl @immortal-tofu ?