Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project list implementation #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

eiriksm
Copy link
Collaborator

@eiriksm eiriksm commented Sep 4, 2018

No description provided.

@zaporylie
Copy link
Owner

You mind if I add you as co-maintainer? I have limited resources to test your PR atm.

@eiriksm
Copy link
Collaborator Author

eiriksm commented Sep 4, 2018

Sure, no worries.

If not I would probably just use my pr as a patch.

@codecov-io
Copy link

codecov-io commented Sep 4, 2018

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #5   +/-   ##
=======================================
  Coverage         0%     0%           
- Complexity      531    552   +21     
=======================================
  Files           112    117    +5     
  Lines          1758   1825   +67     
=======================================
- Misses         1758   1825   +67
Impacted Files Coverage Δ Complexity Δ
src/Model/Project/RequestProjectList.php 0% <0%> (ø) 12 <12> (?)
src/Api/Project.php 0% <0%> (ø) 1 <1> (?)
src/Resource/Project/ProjectList.php 0% <0%> (ø) 1 <1> (?)
src/Model/Project/ResponseProjectList.php 0% <0%> (ø) 2 <2> (?)
src/Tripletex.php 0% <0%> (ø) 13 <1> (+1) ⬆️
src/Model/Project/Project.php 0% <0%> (ø) 4 <4> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493e127...58b92ff. Read the comment docs.

@zaporylie
Copy link
Owner

I've forgotten to say something but you're a co-maintainer here @eiriksm. Feel free to merge as you please.

@eiriksm
Copy link
Collaborator Author

eiriksm commented Mar 21, 2024

I did notice that 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants