Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tips: Add Edge as Chrome #443

Merged
merged 1 commit into from
May 23, 2024
Merged

tips: Add Edge as Chrome #443

merged 1 commit into from
May 23, 2024

Conversation

kingthorin
Copy link
Member

  • Relevant tip content and images.

@kingthorin
Copy link
Member Author

I should add a note that while this might be handy for producing it probably isn't a good move for the Ajax Spider or DOM XSS rule.

@kingthorin
Copy link
Member Author

kingthorin commented May 6, 2024

Probably something like:

> [!CAUTION] 
> While this tip might be handy for exploring an app manually it probably IS NOT a good move to set Edge as Chrome for the purposes of the Ajax Spider or DOM XSS rule.

- Relevant tip content and images.

Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
@kingthorin
Copy link
Member Author

Tweaked, ready for review.

Copy link
Member

@ricekot ricekot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Is it worth adding the tips to the website too?

@kingthorin
Copy link
Member Author

Good question. We originally did it here in the hopes that community would contribute, but that hasn't really taken off.

![](images/selenium_options.png)

7. Then when you launch a 'Chrome' browser (either via the toolbar button or manual explore screen), it will launch Edge.
8. Note: You may get a message saying the "Provided browser was not found" when you close Edge :shrug: (just click "Ok" and ignore it.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try use with the official WebDriver for Edge?
https://developer.microsoft.com/en-us/microsoft-edge/tools/webdriver/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And specifying that as the chrome driver? No I didn't.

I can/will 😃

Copy link
Member Author

@kingthorin kingthorin May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately in that case (switching chromedriver for msedgedriver) it refuses to launch the browser at all 😞

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same if I rename the driver 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, they do have their own EdgeDriver class which should address that. The error is not the best but... we could also look at adding support for that (even if we don't bundle the WebDriver).

@kingthorin
Copy link
Member Author

/nudge

@thc202
Copy link
Member

thc202 commented May 23, 2024

Thank you!

@psiinon psiinon merged commit c80fe5d into zaproxy:main May 23, 2024
8 checks passed
@kingthorin kingthorin deleted the tip-edge branch May 23, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants