Skip to content

Replace deprecated code in targeted script #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

thc202
Copy link
Member

@thc202 thc202 commented Jun 28, 2024

Use the requester add-on to display the message in the editor dialogue.

Needs zaproxy/zap-extensions#5542.

Use the requester add-on to display the message in the editor dialogue.

Needs zaproxy/zap-extensions#5542.

Signed-off-by: thc202 <thc202@gmail.com>
@psiinon
Copy link
Member

psiinon commented Jun 28, 2024

Will also need the requester add-on to be released once that PR has been merged?

@thc202
Copy link
Member Author

thc202 commented Jun 28, 2024

Does not need to be done "now" but we should release the requester add-on before releasing this one.

@psiinon
Copy link
Member

psiinon commented Jun 28, 2024

People might use these as examples on their own, without using the add-on.
If they do that before the requester is released then this script will fail.

@thc202
Copy link
Member Author

thc202 commented Jun 28, 2024

This can wait for the release then.

@kingthorin
Copy link
Member

Changes look good to me

@psiinon psiinon merged commit 4344c70 into zaproxy:main Jun 28, 2024
9 checks passed
@thc202 thc202 deleted the rm-deprecation branch June 28, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants