feat!: push to injector instead of adding configmaps to the cluster #4227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I consider this blocked for now as it conflicts with the implementation of 0033-registry-proxy
This will not be officially ready for review until zarf-dev/zarf-injector#40 is merged and released.
Now that the Zarf injector no longer puts together configmaps and ensures all of those configmaps together have a certain sha creators of custom init package should be encouraged to sha their registry image. Someone with access to port-forward services in the cluster can push to the injector registry and override an image.
If users try to
zarf package deployan older version of the init package with an init package generated after this PR is created then it will fail since the injector no longer has the configmap logic. I believe this is okay as users should usezarf initto deploy the init package.This also moves the injector to internal as it's very specific to the init deploy lifecycle.
Having a mechanism to push makes it easier to rely on additional images from the injector such as a proxy image, without making init take longer.
Checklist before merging