Skip to content

Conversation

@AustinAbro321
Copy link
Member

@AustinAbro321 AustinAbro321 commented Oct 2, 2025

Description

I consider this blocked for now as it conflicts with the implementation of 0033-registry-proxy

This will not be officially ready for review until zarf-dev/zarf-injector#40 is merged and released.

Now that the Zarf injector no longer puts together configmaps and ensures all of those configmaps together have a certain sha creators of custom init package should be encouraged to sha their registry image. Someone with access to port-forward services in the cluster can push to the injector registry and override an image.

If users try to zarf package deploy an older version of the init package with an init package generated after this PR is created then it will fail since the injector no longer has the configmap logic. I believe this is okay as users should use zarf init to deploy the init package.

This also moves the injector to internal as it's very specific to the init deploy lifecycle.

Having a mechanism to push makes it easier to rely on additional images from the injector such as a proxy image, without making init take longer.

Checklist before merging

Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@netlify
Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit a0da2d5
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/68de99761dd5f00008286748

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 46.93878% with 26 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/deploy.go 0.00% 20 Missing ⚠️
src/internal/packager/images/push.go 0.00% 2 Missing and 1 partial ⚠️
src/internal/packager/injector/injector.go 88.46% 2 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
src/internal/packager/images/push.go 51.25% <0.00%> (-0.79%) ⬇️
src/internal/packager/injector/injector.go 72.72% <88.46%> (ø)
src/pkg/packager/deploy.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AustinAbro321 AustinAbro321 changed the title feat: push to injector instead of adding configmaps to the cluster feat!: push to injector instead of adding configmaps to the cluster Oct 2, 2025
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321
Copy link
Member Author

Closing this as we are pausing work on zarf-dev/zarf-injector#41, as it currently conflicts with https://github.com/zarf-dev/proposals/tree/main/0033-registry-proxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants