Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https access fix #196

Merged
merged 4 commits into from
Jul 23, 2024
Merged

https access fix #196

merged 4 commits into from
Jul 23, 2024

Conversation

ayushnag
Copy link
Contributor

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jul 19, 2024

Thanks for tracking this down. I think that at

vds = open_virtual_dataset(url, reader_options={}, indexes={})
, the reader_options={} can be removed and act as a test for this.

@TomNicholas
Copy link
Member

Thanks @ayushnag! Yes I agree with @TomAugspurger - any bugfix should really be accompanied by a regression test, and Tom's suggestion seems like an easy way to add this.

@TomNicholas TomNicholas added the remote files Reading references from non-local files label Jul 21, 2024
@TomNicholas TomNicholas merged commit 179bb2a into zarr-developers:main Jul 23, 2024
7 checks passed
@TomNicholas
Copy link
Member

Thanks @ayushnag !

@ayushnag ayushnag deleted the https_fix branch October 9, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remote files Reading references from non-local files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

open_virtual_dataset HTTPS access fails
3 participants