-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix determination of which variables are coordinates #224
Open
TomNicholas
wants to merge
9
commits into
main
Choose a base branch
from
coords_fix2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
TomNicholas
temporarily deployed
to
test-release
August 23, 2024 22:04
— with
GitHub Actions
Inactive
I've now started doing this, and the general approach seems promising (cc @sharkinsspatial). I have 2 issues to solve before I can properly bug-hunt:
|
TomNicholas
temporarily deployed
to
test-release
August 27, 2024 13:23
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to supercede #191 as a general solution to the problem of (e.g. #189).
I do think though that in order to get this test to fully pass (i.e. identify all the coordinates according to the CF conventions, then we need to use
xr.decode_cf
as described in #157 (comment)).However, I'm currently having weird issues where my test is not behaving deterministically when running locally. The set of coords identified is not the same on every run!
docs/releases.rst
New functions/methods are listed inapi.rst
New functionality has documentation