-
-
Notifications
You must be signed in to change notification settings - Fork 361
fix:*-like creation routines take kwargs #2992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:*-like creation routines take kwargs #2992
Conversation
requesting review from @jhamman since I think you touched this code most recently |
…into fix/zeros-like-takes-kwargs
our upstream tests are failing because fsspec and s3fs tips are incompatible. this failure has nothing to do with this PR. |
…into fix/zeros-like-takes-kwargs
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2992 +/- ##
==========================================
+ Coverage 61.23% 61.24% +0.01%
==========================================
Files 83 83
Lines 9897 9907 +10
==========================================
+ Hits 6060 6068 +8
- Misses 3837 3839 +2
🚀 New features to boost your workflow:
|
In main, array creation routines that take an existing array, like
full_like
,zeros_like
, etc, don't allow users to override certain array properties (like shape and dtype) via keyword arguments. E.g.,full_like(arr, shape=(10,))
will ignore theshape
keyword argument and produce an array with the same shape asarr
.This PR makes these array creation routines sensitive to keyword arguments like
shape
,dtype
,chunks
, etc.closes #2989