Skip to content

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Apr 17, 2025

In main, array creation routines that take an existing array, like full_like, zeros_like, etc, don't allow users to override certain array properties (like shape and dtype) via keyword arguments. E.g., full_like(arr, shape=(10,)) will ignore the shape keyword argument and produce an array with the same shape as arr.

This PR makes these array creation routines sensitive to keyword arguments like shape, dtype, chunks, etc.

closes #2989

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Apr 17, 2025
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Apr 17, 2025
@d-v-b d-v-b requested a review from jhamman April 20, 2025 19:34
@d-v-b
Copy link
Contributor Author

d-v-b commented Apr 20, 2025

requesting review from @jhamman since I think you touched this code most recently

@d-v-b
Copy link
Contributor Author

d-v-b commented May 23, 2025

our upstream tests are failing because fsspec and s3fs tips are incompatible. this failure has nothing to do with this PR.

@d-v-b d-v-b requested a review from TomAugspurger May 23, 2025 12:02
@d-v-b d-v-b enabled auto-merge (squash) September 17, 2025 21:05
@d-v-b d-v-b merged commit 62551c7 into zarr-developers:main Sep 17, 2025
29 checks passed
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 64.28571% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.24%. Comparing base (6805332) to head (4186442).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/zarr/api/asynchronous.py 64.28% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2992      +/-   ##
==========================================
+ Coverage   61.23%   61.24%   +0.01%     
==========================================
  Files          83       83              
  Lines        9897     9907      +10     
==========================================
+ Hits         6060     6068       +8     
- Misses       3837     3839       +2     
Files with missing lines Coverage Δ
src/zarr/api/asynchronous.py 72.20% <64.28%> (+0.27%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b d-v-b deleted the fix/zeros-like-takes-kwargs branch September 17, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] Function zeros_like ignores overrides in keyword arguments (e.g. chunks, dtype).
3 participants