Apply ruff preview rule

[DimitriPapadopoulos]

Also a couple Pylint rules that may not yet be implemented in ruff.

TODO:

• Add unit tests and/or doctests in docstrings
• Add docstrings and API docs for any new/modified user-facing classes and functions
• New/modified features documented in docs/user-guide/*.rst
• Changes documented as a new file in changes/
• GitHub Actions have all passed
• Test coverage is 100% (Codecov passes)

[dstansby]

I'm 👍 for spelling fixes, and 👎 for refactoring without a linter doing it automatically for us (because it just creates PR review noise for not much technical debt reduction). Could you open a PR to repalce this that just includes the spelling fixes?

[DimitriPapadopoulos]

I think Sourcery applies linter rules, but rules that might not be part of ruff (yet). More importantly, I think Sourcery is a good addition - AI assistance for PR review. But I understand you don't agree with it.

Some of the Sourcery suggestions do improve source code are harmful, such as:

-    n_ellipsis = sum(1 for i in selection if i is Ellipsis)
+    n_ellipsis = selection.count(Ellipsis)

How about keeping the couple changes that really make sense?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.07%. Comparing base (ee9c182) to head (49fc9a3).

❗ There is a different number of reports uploaded between BASE (ee9c182) and HEAD (49fc9a3). Click for more details.

HEAD has 3 uploads less than BASE

Flag	BASE (ee9c182)	HEAD (49fc9a3)
	13	10

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3131       +/-   ##
===========================================
- Coverage   94.92%   61.07%   -33.86%     
===========================================
  Files          79       79               
  Lines        9500     9500               
===========================================
- Hits         9018     5802     -3216     
- Misses        482     3698     +3216     

Files with missing lines	Coverage Δ
src/zarr/core/metadata/v2.py	58.13% <100.00%> (-33.14%)	⬇️

... and 66 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.