Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the Position type is exclusively used with leaves, propose a readabil… #83

Closed
wants to merge 1 commit into from

Conversation

zancas
Copy link
Contributor

@zancas zancas commented Jul 6, 2023

This proposes a readability enhancing rename to LeafPosition

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm -1 on this change. It's a breaking change to a public API, and I don't think there's really any ambiguity in the name Position. The Zcash protocol spec just uses "position" or "note position".

@str4d
Copy link
Contributor

str4d commented Jul 25, 2023

Also -1. "Note position" only makes sense in the context of Zcash, and "position" is never used to refer to anything but leaves. For interior nodes we use "index" to refer to their horizontal distance from the left side of the tree (equivalent of "position" for leaves), but interior nodes can't be referenced without a full Address (whereas leaves have an implicit level of 0).

@str4d str4d closed this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants